-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root #45955
Conversation
Is this route actually used in NC28? The security headers check was migrated in NC29. Previously |
It’s cleaner to have the route in the system since it exists. And if the migration of the check is ever backported we won’t get a bug from it. |
…dle redirected root Signed-off-by: Steve Mokris <steve@kosada.com>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
03d7960
to
82f9c66
Compare
Pushed b5cf099 to fix the failing test. The router uses include_once to load route definitions from the apps. First include_once for apps/files/appinfo/routes.php returns the expected array. Second include_once returns true, because the file was already included. To workaround the tests must run in a separate process. I have no idea why the test is not failing on master. |
That does not seem to work
The test is not failing on master because the app manager instance is mocked, the app path is null and the routing file not even included: #46416 |
b5cf099
to
82f9c66
Compare
Backport of PR #45228